fix: remove twig extension if TwigBundle is not installed #974
Conversation
|
Hi @Nyholm! Thanks for opening the PR, it looks good to me! The pipelines are a bit broken right now because of security advisories. We will most likely fix this by Monday and then we can get this PR merged |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (!$isConfigEnabled) { | ||
| $container->removeDefinition(TwigSentryExtension::class); |
There was a problem hiding this comment.
Bug: TwigSentryExtension incorrectly removed when tracing disabled
TwigSentryExtension is being removed when Twig tracing is disabled, preventing users from using Twig functions like sentry_trace_meta() even when Twig is installed. TwigSentryExtension provides general Sentry Twig functions and should only be removed when Twig itself isn't installed (already handled at line 75), not when tracing is disabled. Only TwigTracingExtension should be removed when tracing is disabled.
| // Remove Twig extension service if Twig is not installed to avoid autoloading failures on Symfony 8 | ||
| if (!class_exists(\Twig\Extension\AbstractExtension::class)) { | ||
| $container->removeDefinition(\Sentry\SentryBundle\Twig\SentryExtension::class); | ||
| $container->removeDefinition(TwigSentryExtension::class); |
There was a problem hiding this comment.
Bug: TwigTracingExtension not removed when Twig unavailable
When AbstractExtension doesn't exist (Twig not installed), only TwigSentryExtension is removed. However, TwigTracingExtension also extends AbstractExtension and will cause autoloading failures if Twig is unavailable. Both extensions should be removed when checking for Twig availability to prevent compilation errors on Symfony 8.
|
@Nyholm This might have become obsolete because of a guard introduced in the Symfony 8 PR that I merged today: Do you mind checking against |
2 participants
Description
When running this without twig I get build errors because we are missing Twigs AbstractExtension
Issues
Reminders
feat:,fix:,ref:,meta:)